removed obselete gson-2.6.2 dependency. #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@drapostolos Can you sign CLA? LGTM 👍 |
|
@drapostolos Ok. I have merged it. Please sign CLA next time. Ok? |
TikhomirovSergey
pushed a commit
that referenced
this pull request
Nov 18, 2016
* Fixed broken tests Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before * Added 'touch_id' endpoint (See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature. * removed obselete gson-2.6.2 dependency. (#507) * Fix documentation * Fix documentation * Don't commit 'touchID()' This will be added post release * Added touchId test This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions. * Added assertion to keep codacy happy * Fixed broken tests Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before * Added 'touch_id' endpoint (See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature. * Fix documentation * Fix documentation * Don't commit 'touchID()' This will be added post release * Added touchId test This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions. * Added assertion to keep codacy happy * Moved touchID into new file -Moved touchID out of IOSDeviceActionShorcuts and into PerformsTouchID -Made IOSDriver implement PerformsTouchID -Fixed typo that I noticed in CommandExecutionHelper -Fixed linting errors * Fixed conflicts * Update IOSMobileCommandHelper.java * Throws exception instead of bogus assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Removed dependency from
build.gradledependencies list:compile 'com.google.code.gson:gson:2.6.2'as there already is a later version (
2.7) included in the dependencies list.Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails