Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added System Port capability in AndroidMobileCapabilityType #591

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Added System Port capability in AndroidMobileCapabilityType #591

merged 1 commit into from
Mar 6, 2017

Conversation

priyankshah217
Copy link
Contributor

Change list

When automation to be run with UIAutomator2 capability for android, often instrumentation crash.
To mitigate we need to provide "systemPort" capability as a part of desired capability.
This minor change and just tokenise "systenPort" into AndroidMobileCapability.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

As per @sravanmedarapu suggestion, In order to run Appium test with UIAutomator2 capability; it requires systemPort capability to be provided to keep parallel sessions alive. For further detail please find below link,
appium/appium#7745 (comment)

This changes is just tokenise "systemPort" capability into AndroidMobileCapability and its a very minor change to java-client.

@TikhomirovSergey TikhomirovSergey self-requested a review March 6, 2017 19:53
@TikhomirovSergey TikhomirovSergey merged commit dd2a372 into appium:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants