-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable nativeWebTap setting for iOS #658
Conversation
@jlipps Looks good overall. Can you add some tests please? Also our travis is not happy. |
@SrinivasanTarget added tests, and ran it locally with success. note that this will probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download. not sure what the appium local service runs in the java client... but anyway it works! |
found the javadoc error that was failing travis. hopefully it will pass now. |
We have excluded running tests in CI, so it wouldn't be a problem now. Also this is in pipeline for us.
Appium local service runs appium as a service automatically at stated port,etc without being started manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Great! Now how do we publish a beta so someone can use it? :-) |
Change list
add a setting for iOS to toggle
nativeWebTap
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Server-side change: appium/appium-xcuitest-driver#455