Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable nativeWebTap setting for iOS #658

Merged
merged 4 commits into from
Jun 17, 2017
Merged

enable nativeWebTap setting for iOS #658

merged 4 commits into from
Jun 17, 2017

Conversation

jlipps
Copy link
Member

@jlipps jlipps commented Jun 16, 2017

Change list

add a setting for iOS to toggle nativeWebTap

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Server-side change: appium/appium-xcuitest-driver#455

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 16, 2017

@jlipps Looks good overall. Can you add some tests please? Also our travis is not happy.

@jlipps
Copy link
Member Author

jlipps commented Jun 16, 2017

@SrinivasanTarget added tests, and ran it locally with success. note that this will probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download. not sure what the appium local service runs in the java client... but anyway it works!

@jlipps
Copy link
Member Author

jlipps commented Jun 16, 2017

found the javadoc error that was failing travis. hopefully it will pass now.

@SrinivasanTarget
Copy link
Member

probably fail CI since it is set to iOS 10.2 and requires appium 1.6.6-beta.2 with a fresh download

We have excluded running tests in CI, so it wouldn't be a problem now. Also this is in pipeline for us.

not sure what the appium local service runs in the java client

Appium local service runs appium as a service automatically at stated port,etc without being started manually.

Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jlipps jlipps merged commit 37f5ed3 into master Jun 17, 2017
@jlipps jlipps deleted the jlipps-nwt branch June 17, 2017 00:29
@jlipps
Copy link
Member Author

jlipps commented Jun 17, 2017

Great! Now how do we publish a beta so someone can use it? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants