Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address compilation error with selenium 3.5.1 #698

Closed
wants to merge 1 commit into from
Closed

Address compilation error with selenium 3.5.1 #698

wants to merge 1 commit into from

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Fix compilation error with selenium 3.5.1 module (see https://travis-ci.org/appium/java-client/builds/266018745)

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Run several functional tests and the stuff looks good so far. However, it would be good to run more extended suite.

SrinivasanTarget
SrinivasanTarget approved these changes Aug 19, 2017
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@SrinivasanTarget SrinivasanTarget mentioned this pull request Aug 19, 2017
Closed
@TikhomirovSergey TikhomirovSergey mentioned this pull request Aug 20, 2017
Merged
4 tasks
@mykola-mokhnach
Copy link
Contributor Author

Closed as a subpart of #699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@TikhomirovSergey TikhomirovSergey TikhomirovSergey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykola-mokhnach @TikhomirovSergey @SrinivasanTarget @ukostas