Add pushFile support to IOSDriver #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@mykola-mokhnach
It looks ok. But I have a question. What the difference between the PushesFiles in the android package and the PushesFiles in the ios package? Maybe it has more sense to move interface to the java_client
|
For iOS the documentation differs, wince the call works for Simulator only, but the body is the same. Frankly speaking, I don't see a need to extract these methods into a common lib - they anyway contain 1 to 3 lines of code. Even the documentation takes more space |
|
@mykola-mokhnach ok. So lets wait the result from CI. |
TikhomirovSergey
approved these changes
Sep 8, 2017
|
@KazuCocoa FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
The PR adds support of pushFile endpoint to IOSDriver. For now it is only possible to upload media file to Simulator.
Types of changes
Details
Addresses #720