Add endpoints for screen recording API for iOS and Android #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
TikhomirovSergey
suggested changes
Jan 20, 2018
There was a problem hiding this comment.
@mykola-mokhnach There is the conflict. Could you resolve it?
Will try it ASAP .
mykola-mokhnach
force-pushed
the
record_screen
branch
from
0d3dee5 to
4d5b243
Compare
|
Rebased it with master |
SrinivasanTarget
requested changes
Jan 23, 2018
|
@SrinivasanTarget I would be happy to add tests, but currently the client interaction with Appium beta is broken, so I cannot even init a session properly. See appium/appium#10055 for more details. |
@mykola-mokhnach Yes just looking at it. I think we need to work on W3C support asap from your other PR. |
|
@TikhomirovSergey @SrinivasanTarget The recent server beta has a workaround for w3c issue, so I was able to create and check integration tests for the feature. |
mykola-mokhnach
force-pushed
the
record_screen
branch
from
96d8eff to
5e26f0e
Compare
SrinivasanTarget
approved these changes
Feb 1, 2018
mykola-mokhnach
force-pushed
the
record_screen
branch
from
5e26f0e to
89d62e4
Compare
TikhomirovSergey
approved these changes
Feb 7, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Add endpoints for screen recording API for iOS and Android
Types of changes
Details
appium/appium-android-driver#303
appium/appium-xcuitest-driver#609