-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update applications management endpoints #824
Update applications management endpoints #824
Conversation
@mykola-mokhnach nice 💥 🌟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome... I liked the PR 👍 Good to have some tests after the other PRs merged.
Added integration tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach Hello
Sorry for the late response.
It is looking good bot it seems there are few issues.
- I can't get the test passing
JSOWP: https://gist.github.com/TikhomirovSergey/02297557728a3d37a2ff845f63511724
W3C: https://gist.github.com/TikhomirovSergey/db01594b178d175c0691818488c4f642
Also:
- should be there options for iOS? Or is it Android-specific feature
- I think it has sense to move Android-specific classes to the
io.appium.java_client.android
packege. The same is for iOS.
There are no special options for iOS for now, but the API has a possibility to add them.
np, will do.
I see the problem now. Will add the necessary changes to the server code. I was testing it with my local server code a while ago %) |
a00e08f
to
fe63a94
Compare
The server code has been updated in the recent beta. Can you please try the test now @TikhomirovSergey ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach I'm getting below error. Can you check this?
https://gist.github.com/SrinivasanTarget/8e541f1e984cd224df5038bfceeec13a
I'm using latest appium server from master.
@SrinivasanTarget appium/appium-uiautomator2-driver#141 should be published first. Try xcuitest driver instead. |
@mykola-mokhnach Its same for iOS as well. Isn't it published yet for iOS too? |
@SrinivasanTarget yes,, I've just tested it on the recent beta build |
Although, I had to update some iOS capabilities: File app = new File("UICatalog-iphonesimulator.app");
DesiredCapabilities capabilities = new DesiredCapabilities();
capabilities.setCapability(MobileCapabilityType.BROWSER_NAME, "");
capabilities.setCapability(MobileCapabilityType.PLATFORM_VERSION, "11.2");
capabilities.setCapability(MobileCapabilityType.DEVICE_NAME, "iPhone 6s");
//sometimes environment has performance problems
capabilities.setCapability(IOSMobileCapabilityType.LAUNCH_TIMEOUT, 500000);
capabilities.setCapability(MobileCapabilityType.APP, app.getAbsolutePath());
driver = new IOSDriver<>(service.getUrl(), capabilities); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach works fine with latest server
Change list
This updates application management endpoints according to the recent changes in Android and xcuitest drivers
Types of changes