#846 and #742 FIX #863
Merged
#846 and #742 FIX #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DurationBuilder was added - some changes in WithTimeout to provide backward compatibility
- refactoring of page object tools
- tests were updated
| @@ -62,16 +66,20 @@ | |||
| private static final List<Class<? extends WebElement>> availableElementClasses = ImmutableList.of(WebElement.class, | |||
| RemoteWebElement.class, MobileElement.class, AndroidElement.class, | |||
| IOSElement.class, WindowsElement.class); | |||
| public static Duration DEFAULT_WAITING_TIMEOUT = ofSeconds(1); | |||
| return Duration.of(withTimeout.time(), withTimeout.chronoUnit()); | ||
| } | ||
|
|
||
| return Duration.of(MILLISECONDS.convert(withTimeout.time(), withTimeout.unit()), MILLIS); |
There was a problem hiding this comment.
is FOREVER the same as milliseconds?
There was a problem hiding this comment.
I was forced to add defalt values (FOREVER and NANOSECONDS) for bacward compatibility (temporary). Comilation problems will occure otherewise. User will be forced to set both time units.
There was a problem hiding this comment.
@mykola-mokhnach However
Can we consider FOREVER illegal value? I think it has some sense.
There was a problem hiding this comment.
I don't know, but it for sure does not help to read and understand the code.
| @@ -48,7 +48,7 @@ | |||
| File appDir = new File("src/test/java/io/appium/java_client"); | |||
| File app = new File(appDir, "ApiDemos-debug.apk"); | |||
| DesiredCapabilities capabilities = new DesiredCapabilities(); | |||
| capabilities.setCapability(MobileCapabilityType.AUTOMATION_NAME, AutomationName.ANDROID_UIAUTOMATOR2); | |||
| capabilities.setCapability(MobileCapabilityType.AUTOMATION_NAME, AutomationName.APPIUM); | |||
There was a problem hiding this comment.
why this is changed?
There was a problem hiding this comment.
It was for local debugging. Will revert it
SrinivasanTarget
approved these changes
Apr 9, 2018
mykola-mokhnach
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
Details
I am sorry for the long break. Was busy.