Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid amending parameters for SET_ALERT_VALUE endpoint #867

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Avoid amending parameters for SET_ALERT_VALUE endpoint #867

merged 1 commit into from
Apr 12, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

The previous implementation was crashing in W3C mode, since we always only set value argument and selenium hook expects text to be set as well while performing parameters amend. W3C spec itself only has value description.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@SrinivasanTarget SrinivasanTarget merged commit 3bfe707 into appium:master Apr 12, 2018
@mykola-mokhnach mykola-mokhnach deleted the alert_text branch April 12, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykola-mokhnach @SrinivasanTarget