Support syslog broadcast with iOS #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.Collections; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public interface ListensToSyslogMessages extends ExecutesMethod { |
There was a problem hiding this comment.
@mykola-mokhnach Its same as Logcat Listerners which you have added some time back. Any reason why both are separate interfaces apart from naming convention of Logcat for Android and Syslog for iOS? Do you forcast anything in future where we will have it in android and not in iOS or viceviz.
There was a problem hiding this comment.
yep, I think something may change there, so we keep it separate for both platforms. Would you prefer to combine the interfaces?
|
I am waiting for @SrinivasanTarget 's approval because I can't check iOS part. |
SrinivasanTarget
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Based on appium/appium-xcuitest-driver#653
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply