-
-
Notifications
You must be signed in to change notification settings - Fork 766
Add isKeyboardShown command for iOS #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
e7ea751
0eb57d9
731d44a
51c19b5
739c7f9
c3ab993
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package io.appium.java_client; | ||
|
||
import static io.appium.java_client.MobileCommand.isKeyboardShownCommand; | ||
|
||
public interface HasDeviceDetails extends ExecutesMethod { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather rename the interface to HasOnScreenKeyboard There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm makes sense |
||
|
||
/** | ||
* Check if the keyboard is displayed. | ||
* | ||
* @return true if keyboard is displayed. False otherwise | ||
*/ | ||
default boolean isKeyboardShown() { | ||
return CommandExecutionHelper.execute(this, isKeyboardShownCommand()); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ | |
public class AndroidDriver<T extends WebElement> | ||
extends AppiumDriver<T> | ||
implements PressesKeyCode, HasNetworkConnection, PushesFiles, StartsActivity, | ||
FindsByAndroidUIAutomator<T>, LocksDevice, HasAndroidSettings, HasDeviceDetails, | ||
FindsByAndroidUIAutomator<T>, LocksDevice, HasAndroidSettings, HasAndroidDeviceDetails, | ||
HasSupportedPerformanceDataType, AuthenticatesByFinger, | ||
CanRecordScreen, SupportsSpecialEmulatorCommands, | ||
SupportsNetworkStateManagement, ListensToLogcatMessages, HasAndroidClipboard { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The interface should be added to AndroidDriver as well |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather add it to only ios and Android drivers, but not to the generic one.