feat: add app_path property ("appPath") to Mac2Options #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Aug 17, 2024
|
Thank you @a-fultz Could you please rename the PR to satisfy conventional commits naming rules.
|
a-fultz
changed the title
KazuCocoa
approved these changes
Aug 17, 2024
|
Hi @a-fultz , congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you! |
|
@jlipps it is af2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting the optional appPath capability via Mac2Options().app_path, aligning with the related "bundle_id" setting. Presently it is necessary to pass in a value for appPath as part of the capabilities dictionary to Mac2Options().load_capabilities() if you wish to set it.
appPath is implemented in the Mac2 driver:
https://github.com/appium/appium-mac2-driver?tab=readme-ov-file#capabilities