Add execute driver #406
Merged
Add execute driver #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Jun 21, 2019
|
|
||
| class ExecuteDriver(webdriver.Remote): | ||
|
|
||
| def execute_driver(self, script, script_type='webdriverio', timeout=None): |
There was a problem hiding this comment.
timeout_ms might be a better arg name
| self.driver.quit() | ||
|
|
||
| def test_batch(self): | ||
| script = """ |
There was a problem hiding this comment.
ki4070ma
reviewed
Jun 22, 2019
| self.driver.execute_driver(script='return [];', script_type='webdriverio', timeout=10000) | ||
|
|
||
| Return: | ||
| Dir[str, any]: The result of the script. It has 'result' and 'logs' keys. |
| self.driver.execute_driver(script='return [];', script_type='webdriverio') | ||
| self.driver.execute_driver(script='return [];', script_type='webdriverio', timeout=10000) | ||
|
|
||
| Return: |
There was a problem hiding this comment.
| d = get_httpretty_request_body(httpretty.last_request()) | ||
| assert d['script'] == script | ||
| assert d['type'] == 'webdriverio' | ||
| assert 'timeout' not in d |
There was a problem hiding this comment.
'timeout' not in d.keys() ?
There was a problem hiding this comment.
Current way is fine
>>> d = {'timeout': 1}
>>> 'timeout' in d
True
>>> 'timeout' in d.keys()
True
ki4070ma
reviewed
Jun 22, 2019
ki4070ma
approved these changes
Jun 22, 2019
mykola-mokhnach
approved these changes
Jun 22, 2019
| """ | ||
|
|
||
| result = self.driver.execute_driver(script=textwrap.dedent(script)) | ||
| r = result.result[0].rect |
There was a problem hiding this comment.
I's say it is a bit confusing to have result.result mapping. What if we rename the retuned variable to response ?
There was a problem hiding this comment.
ah. Nice. Yeah, I forgot re-naming it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for appium/appium-base-driver#328
Added execute_driver as the new feature.
You can try the feature as
$ pytest test/functional/ios/execute_driver_tests.pyafter applying the base driver PR on your local. I'll update this PR if something changes in the base driver PR.