Skip to content

feat: Remove deprecated timeout #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

feat: Remove deprecated timeout #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8315c2
remove deprecated Selenium::WebDriver::Error::TimeOutError
KazuCocoa Jun 8, 2020
0b2d935
update
KazuCocoa Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Read `release_notes.md` for commit level details.
## [Unreleased]

### Enhancements
- Remove deprecated `Selenium::WebDriver::Error::TimeOutError` in `webdriver-selenium` gem

### Bug fixes

Expand Down
4 changes: 0 additions & 4 deletions lib/appium_lib_core/common/base/search_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ def find_element(*args)
by = _set_by_from_finders(how)
begin
bridge.find_element_by by, what.to_s, ref
rescue Selenium::WebDriver::Error::TimeOutError # will deprecate
raise Selenium::WebDriver::Error::NoSuchElementError
rescue Selenium::WebDriver::Error::TimeoutError
raise Selenium::WebDriver::Error::NoSuchElementError
end
Expand All @@ -152,8 +150,6 @@ def find_elements(*args)
by = _set_by_from_finders(how)
begin
bridge.find_elements_by by, what.to_s, ref
rescue Selenium::WebDriver::Error::TimeOutError # will deprecate
[]
rescue Selenium::WebDriver::Error::TimeoutError
[]
end
Expand Down