Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rust Port #13

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[WIP] Rust Port #13

wants to merge 8 commits into from

Conversation

ds-ak
Copy link

@ds-ak ds-ak commented Jun 27, 2023 •
edited
Loading

  • Base logging infra
  • Same API as previous pure-python logger (Except setLevel has been renamed to set_level for consistency)
  • Log to file
  • Log to Slack
  • tpl Template implementation (tpl.format() is now tpl())
  • [CRITICAL] Hangs for pytest (probably we are not being smart about Mutex; debugging required)
  • Colors
  • NEVER Panic
  • Parent-Child logger [hopefully not required]
  • async within rust-layer [optional]

@ds-ak ds-ak changed the title Rust Port [WIP] Rust Port Jun 27, 2023
@ds-ak ds-ak requested a review from cosmosgenius June 28, 2023 01:33
grv07
grv07 reviewed Jun 28, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grv07 grv07 grv07 left review comments

@cosmosgenius cosmosgenius Awaiting requested review from cosmosgenius

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds-ak @grv07 @dhilipsiva