-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
Merge pull request #1466 from appknox/PD-1541-fix-analysis-details-css
fix analysis details css issues
Showing
15 changed files
with
560 additions
and
429 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.file-compare-tabs { | ||
position: sticky; | ||
margin-top: 1.4286em; | ||
top: calc(200px - 0.5em); | ||
top: calc(198px - 0.5em); | ||
z-index: 10; | ||
background: var(--file-compare-tabs-background-color); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 36 additions & 37 deletions
73
...nts/file-details/vulnerability-analysis-details/findings/custom-vulnerabilities/index.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,45 @@ | ||
<div | ||
local-class='analysis-section {{if | ||
@analysis.isOverriddenAsPassed | ||
"analysis-overridded-passed" | ||
@analysis.isOverriddenAsPassed | ||
"analysis-overridded-passed" | ||
}}' | ||
class='mb-2' | ||
data-test-analysisDetails-vulnerabilityContainer | ||
> | ||
<AkStack local-class='analysis-content-title'> | ||
<AkTypography | ||
data-test-analysisDetails-vulnerabilityTitle | ||
@variant='subtitle1' | ||
@gutterBottom={{true}} | ||
> | ||
{{#if | ||
(and @analysis.isRiskPassedBySystem (gt @analysis.findings.length 0)) | ||
}} | ||
{{t 'evidences'}} | ||
{{else}} | ||
{{t 'vulnerability'}} | ||
{{/if}} | ||
</AkTypography> | ||
</AkStack> | ||
<AkStack local-class='analysis-content-title'> | ||
<AkTypography | ||
data-test-analysisDetails-vulnerabilityTitle | ||
@variant='subtitle1' | ||
> | ||
{{#if | ||
(and @analysis.isRiskPassedBySystem (gt @analysis.findings.length 0)) | ||
}} | ||
{{t 'evidences'}} | ||
{{else}} | ||
{{t 'vulnerability'}} | ||
{{/if}} | ||
</AkTypography> | ||
</AkStack> | ||
|
||
<div class='p-3'> | ||
{{#each @customVulnerableFindings as |finding idx|}} | ||
{{#if finding.title}} | ||
<AkTypography | ||
data-test-analysisDetails-vulFindingTitle='{{idx}}' | ||
local-class='analysis-content-value' | ||
> | ||
{{finding.title}} | ||
</AkTypography> | ||
{{/if}} | ||
<div local-class='analysis-content-container' class='p-3'> | ||
{{#each @customVulnerableFindings as |finding idx|}} | ||
{{#if finding.title}} | ||
<AkTypography | ||
data-test-analysisDetails-vulFindingTitle='{{idx}}' | ||
local-class='analysis-content-value' | ||
> | ||
{{finding.title}} | ||
</AkTypography> | ||
{{/if}} | ||
|
||
<div local-class='vulnerability-finding-container'> | ||
<pre | ||
data-test-analysisDetails-vulFindingDescription='{{idx}}' | ||
local-class='vulnerability-finding-description' | ||
> | ||
{{finding.description}} | ||
</pre> | ||
</div> | ||
{{/each}} | ||
</div> | ||
<div local-class='vulnerability-finding-container'> | ||
<pre | ||
data-test-analysisDetails-vulFindingDescription='{{idx}}' | ||
local-class='vulnerability-finding-description' | ||
> | ||
{{finding.description}} | ||
</pre> | ||
</div> | ||
{{/each}} | ||
</div> | ||
</div> |
113 changes: 75 additions & 38 deletions
113
...ts/file-details/vulnerability-analysis-details/findings/custom-vulnerabilities/index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,84 @@ | ||
.analysis-section { | ||
width: 100%; | ||
background-color: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-background-main); | ||
border: 1px solid var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color); | ||
|
||
&.analysis-overridded-passed { | ||
background-color: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-marked-passed-background-color); | ||
|
||
.analysis-static-content pre code, | ||
.vulnerability-finding-container { | ||
background-color: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-marked-passed-code-background-color); | ||
border: 1px solid var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color); | ||
} | ||
} | ||
width: 100%; | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-background-main | ||
); | ||
|
||
&.analysis-overridded-passed { | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-marked-passed-background-color | ||
); | ||
|
||
.analysis-content-title { | ||
padding: 0.75em 1.5em; | ||
border-bottom: 1px solid var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color); | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-marked-passed-background-color | ||
); | ||
} | ||
|
||
h6 { | ||
margin-bottom: 0 !important; | ||
} | ||
.analysis-static-content pre code, | ||
.vulnerability-finding-container { | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-marked-passed-code-background-color | ||
); | ||
border: 1px solid | ||
var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color | ||
); | ||
} | ||
} | ||
|
||
.analysis-content-title { | ||
position: sticky; | ||
top: calc(172px + 1.5em); | ||
z-index: 1; | ||
padding: 1em; | ||
border: 1px solid | ||
var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color | ||
); | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-background-main | ||
); | ||
|
||
.analysis-content-value { | ||
max-width: 460px; | ||
h6 { | ||
margin-bottom: 0 !important; | ||
} | ||
} | ||
|
||
.vulnerability-finding-container { | ||
max-width: 600px; | ||
max-height: 300px; | ||
overflow: auto; | ||
text-overflow: clip; | ||
margin: 1em 0; | ||
background-color: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-code-background-color); | ||
border-radius: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-radius); | ||
|
||
.vulnerability-finding-description { | ||
background-color: unset; | ||
color: var(--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-color-primary); | ||
white-space: pre-line; | ||
width: max-content; | ||
line-height: normal; | ||
padding: 0.75em; | ||
} | ||
.analysis-content-container { | ||
border-width: 0 1px 1px; | ||
border-style: solid; | ||
border-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-color | ||
); | ||
} | ||
|
||
.analysis-content-value { | ||
max-width: 460px; | ||
} | ||
|
||
.vulnerability-finding-container { | ||
max-width: 600px; | ||
max-height: 300px; | ||
overflow: auto; | ||
text-overflow: clip; | ||
margin: 1em 0; | ||
background-color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-code-background-color | ||
); | ||
border-radius: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-border-radius | ||
); | ||
|
||
.vulnerability-finding-description { | ||
background-color: unset; | ||
color: var( | ||
--file-details-vulnerability-analysis-details-findings-custom-vulnerabilities-color-primary | ||
); | ||
white-space: pre-line; | ||
width: max-content; | ||
line-height: normal; | ||
padding: 0.75em; | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.