dynamic scan e2e fix & snapshot update

[future-pirate-king]

No description provided.

[coderabbitai]

Walkthrough

The pull request introduces modifications across several files. In the index.hbs file, data-test-cy attributes are added to two AkSelect components for device type and OS version selection. The doFilePageSanityCheck method in the DynamicScanActions class is updated to include additional assertion options. Finally, the dynamic-scan.spec.ts file refines test assertions by replacing previous selectors with more precise ones and adds comments for improved clarity.

Changes

File Path	Change Summary
app/components/project-preferences/device-preference/index.hbs	Added data-test-cy attributes to two AkSelect components for device type and OS version.
cypress/support/Actions/common/DynamicScanActions.ts	Modified doFilePageSanityCheck method to include DEFAULT_ASSERT_OPTS in assertion methods.
cypress/tests/dynamic-scan.spec.ts	Enhanced test assertions by using cy.findByText(...) and cy.findByTestId(...), and added comments for clarity.

Poem

In the garden of code, changes bloom bright,
With data-test-cy tags, our tests take flight.
Assertions refined, like a rabbit's swift hop,
Clarity reigns, as we reach for the top.
Hopping through tests, with joy we declare,
Each line a delight, in this code we share! 🐇✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c6d048 and aaf2015.

Files ignored due to path filters (3)

• cypress/snapshots/base/dynamic-scan.spec.ts/mfva_app_info_dialog_cropped.png is excluded by !**/*.png
• cypress/snapshots/base/dynamic-scan.spec.ts/mfva_home_screen_cropped.png is excluded by !**/*.png
• cypress/snapshots/base/dynamic-scan.spec.ts/mfva_open_webview_cropped.png is excluded by !**/*.png

Files selected for processing (3)

• app/components/project-preferences/device-preference/index.hbs (2 hunks)
• cypress/support/Actions/common/DynamicScanActions.ts (2 hunks)
• cypress/tests/dynamic-scan.spec.ts (2 hunks)

Files skipped from review due to trivial changes (1)

• app/components/project-preferences/device-preference/index.hbs

Files skipped from review as they are similar to previous changes (2)

• cypress/support/Actions/common/DynamicScanActions.ts
• cypress/tests/dynamic-scan.spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cypress]

Irene    Run #470

Run Properties:   Failed #470  •  27fce3852d ℹ️: Merge 7c6d048afb9a55e64e66d9388e0134db20355ed0 into a722a1766f4a508a9a2a7d346535...

Project	Irene
Branch Review	dynamic-scan-e2e-fix
Run status	Failed #470
Run duration	13m 27s
Commit	27fce3852d ℹ️: Merge 7c6d048afb9a55e64e66d9388e0134db20355ed0 into a722a1766f4a508a9a2a7d346535...
Committer	Sam David
View all properties for this run ↗︎

---

Test results
Failures	2
Flaky	0
Pending	0
Skipped	1
Passing	19
View all changes introduced in this branch ↗︎

---

Tests for review

  dynamic-scan.spec.ts • 1 failed test

View Output

Test		Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062		Test Replay Screenshots

  service-account.spec.ts • 1 failed test

View Output

Test		Artifacts
Service Account > should create service account without expiry & delete it		Test Replay Screenshots

[cloudflare-workers-and-pages]

Deploying irenestaging with    Cloudflare Pages

Latest commit:	aaf2015
Status:	✅  Deploy successful!
Preview URL:	https://6b4b8a3d.irenestaging.pages.dev
Branch Preview URL:	https://dynamic-scan-e2e-fix.irenestaging.pages.dev

View logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[cypress]

Irene    Run #473

Run Properties:   Passed #473  •  aaf20156ea: dynamic scan e2e fix & snapshot update

Project	Irene
Branch Review	dynamic-scan-e2e-fix
Run status	Passed #473
Run duration	05m 40s
Commit	aaf20156ea: dynamic scan e2e fix & snapshot update
Committer	Sam David
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	22
View all changes introduced in this branch ↗︎