Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse URL Variables #13

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

bl4ckst0ne
Copy link
Contributor

Hey,
In order to support path parameters (for example https://hello.com/example/:someting), Postman uses URL variables.
It is essentially a list of Variable inside the Url object.
There was a declaration for the variable property, but was not parsed.

Therefore, I am adding support for it. 😄

I've tried to follow your code style. Let me know if you've got any problem.

@kirankumbhar
Copy link
Contributor

Hey, @bl4ckst0ne Thank you for the PR. I have reviewed it. While I was going through the schema document, It seems that the default value of variable should be an empty list instead of None.
There are many places the default value needs to be changed.
Can you do it for variable?
So let the default value be empty list and do variable = data.get("variable", [])
Let me know if this is clear to you.

@kirankumbhar
Copy link
Contributor

LGTM

@kirankumbhar kirankumbhar merged commit 81aba1d into appknox:main Apr 26, 2022
@kirankumbhar
Copy link
Contributor

Thank you @bl4ckst0ne for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants