Fix some bugs for mDNSResponder-1790 on linux platform #5
Conversation
| #if MDNSRESPONDER_PLATFORM_APPLE | ||
| __block mStatus err; | ||
| #else | ||
| mStatus err; | ||
| #endif |
There was a problem hiding this comment.
This has been upstreamed in 2200.0.8. Regardless, I don't think they take PRs in these repos.
There was a problem hiding this comment.
Has 2200.0.8 resolved all the issues in this PR? If not, I hope this PR can be merged into 1790. If this PR cannot be merged into 1790, how about resubmitting a PR to the master?
There was a problem hiding this comment.
Probably not all of them, but I've successfully built mDNSResponder on Linux with only 2 minor patches.
As mentioned above, I don't think Apple takes any PRs on this repo though, this looks like a pure source dump/mirror for any libraries they vendor in their OSes. I would probably ask on Apple's developer forum if they have some form of contribution process for OSS patches.
There was a problem hiding this comment.
Thank you for your response. I hope that the upstream provide a channel to accept patches. I am waiting for the upstream to fix the issues in this PR, and then I will create a new package in Conan-Center.
1.Resolve compile errors on linux platform.
2.Resolve the problem that services cannot be discovered after network interface restart.( I found that If the interface restart, the interface object will be change(the interface index remains the same), which will result in services previously bound to the interface's mDNSInterfaceID will not being discovered again)
https://github.com/apple-oss-distributions/mDNSResponder/blob/rel/mDNSResponder-1790/mDNSCore/mDNS.c#L15414
https://github.com/apple-oss-distributions/mDNSResponder/blob/rel/mDNSResponder-1790/mDNSPosix/mDNSPosix.c#L1401
3.Resolve memory leak.
4.Add unicast-disable compile option.
5.Add uds-server path environment variable.
6.Support cross building on linux platform.