Automatically clean up anonymous volumes for containers with --rm flag #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realrajaryan
force-pushed
the
users/realrajaryan/rm-cleanup-anonvolumes
branch
from
ef8edc7 to
b1d37b9
Compare
dcantah
reviewed
Nov 4, 2025
|
|
||
| private func handleContainerExit(id: String, code: ExitStatus? = nil) async throws { | ||
| try await self.lock.withLock { [self] context in | ||
| let shouldCleanupVolumes = try await self.lock.withLock { [self] context in |
There was a problem hiding this comment.
Curious why we don't just do the cleanup in handleContainerExit itself
There was a problem hiding this comment.
Once the lock is released if autoRemove was true, the container bundle has already been deleted by cleanup(), so we can't call getContainerCreationOptions() again to check the flag, the file is gone. So we need to capture the decision while the container still exists (inside the lock) then act on it outside the lock
There was a problem hiding this comment.
What I mean is if cleanup() is called we know that autoRemove was supplied, so why not just do it in there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Adds automatic cleanup of anonymous volumes when containers started with the
--rmflag exit, preventing orphaned volumes from accumulating and consuming disk space.Testing