ci: add stale PR management workflow #853

Ronitsabhaya75 · 2025-11-05T15:22:01Z

Type of Change

Bug fix
New feature
Breaking change
Documentation update

Motivation and Context

PRs inactive for 30 days → marked as stale with friendly reminder
PRs inactive for 45 days → automatically closed
Security, critical, and dependency PRs are exempt from auto-closure
Stale label automatically removed if PR is updated

Testing

Tested locally
Added/updated tests
Added/updated docs

katiewasnothere · 2025-11-05T17:15:13Z

.github/workflows/stale-pr.yml

+          days-before-stale: 14
+          days-before-close: 30


I think we should up these numbers to 30 days for stale and 60 days for close, though I'm open to other feedback here.

Ideally things are merged much faster than that, but we should account for large changes that take a while to deliberate and for things like people going on vacations.

I think we should up these numbers to 30 days for stale and 60 days for close, though I'm open to other feedback here.

Ideally things are merged much faster than that, but we should account for large changes that take a while to deliberate and for things like people going on vacations.

I feel like 30 days grace period for making it stale is good and closing should be at 35th or 40th day this way we dont have large numbers of pr gathered.

I'd be more comfortable with giving people a two week period to prevent their work from being closed. How do you feel about closing after 44/45 days?

I'd be more comfortable with giving people a two week period to prevent their work from being closed. How do you feel about closing after 44/45 days?

I feel like 45 days are enough time for closing

katiewasnothere · 2025-11-05T17:17:30Z

.github/workflows/stale-pr.yml

+          days-before-issue-stale: -1
+          days-before-issue-close: -1
+
+          remove-stale-when-updated: true


Probably not super necessary, but we should consider changing this to remove-pr-stale-when-updated.

katiewasnothere · 2025-11-05T17:18:38Z

.github/workflows/stale-pr.yml

+
+            The PR will be closed in 30 days if there's no activity.
+
+            If you need help or have questions, feel free to ask! We appreciate your contribution. 🙏


I'd prefer we remove this emoji

katiewasnothere · 2025-11-05T17:22:18Z

.github/workflows/stale-pr.yml

+          stale-pr-message: |
+            This pull request has been inactive for 2 weeks and will be marked as stale.
+
+            If you're still working on this, please:


Can we make it clear that they only need to do one of the following list?

katiewasnothere · 2025-11-05T17:22:51Z

.github/workflows/stale-pr.yml

+          close-pr-message: |
+            This pull request was automatically closed due to inactivity.
+
+            If you'd like to continue this work, feel free to:


Same thing here, only one option is necessary. Though they should always feel free to comment if they need assistance :)

katiewasnothere · 2025-11-05T17:25:44Z

Thanks for working on this @Ronitsabhaya75, I think this will be really helpful for us to have!

Could you update the PR description to match that this workflow is only for PRs? Since the repo is set to squash commits when we merge PRs, the PR description becomes the squashed commit's message, so we want to make sure we keep that accurate. Thanks!

Ronitsabhaya75 · 2025-11-05T17:37:58Z

for sure katie I can

Thanks for working on this @Ronitsabhaya75, I think this will be really helpful for us to have!

Could you update the PR description to match that this workflow is only for PRs? Since the repo is set to squash commits when we merge PRs, the PR description becomes the squashed commit's message, so we want to make sure we keep that accurate. Thanks!

For sure Katie I'll update the description and update reviewed changes asap.

Thank you so much for review

…emojis

katiewasnothere · 2025-11-05T21:29:14Z

.github/workflows/stale-pr.yml

+          
+          stale-pr-label: 'stale'
+
+          exempt-pr-labels: 'security,critical,dependencies'


We don't have a process for using labels like these today, so I think we should remove this.

ok I'll def remove those labels

katiewasnothere · 2025-11-05T21:34:59Z

.github/workflows/stale-pr.yml

+    permissions:
+      pull-requests: write


@realrajaryan pointed out to me that there's an issue on actions/stale where issues: write was required even when only dealing with PRs here. The last comment on that issue mentions that someone was still hitting it in 2024, so it's possible that this is no longer an issue.

We should find a way to test this flow without needing the PR to be merged. That could look like changing the trigger on the flow and using only-labels to target a specific test label that we can create so we only comment on/close the test PR. Let me know if you want to try this and I can make the test label.

@realrajaryan pointed out to me that there's an issue on actions/stale where issues: write was required even when only dealing with PRs here. The last comment on that issue mentions that someone was still hitting it in 2024, so it's possible that this is no longer an issue.

We should find a way to test this flow without needing the PR to be merged. That could look like changing the trigger on the flow and using only-labels to target a specific test label that we can create so we only comment on/close the test PR. Let me know if you want to try this and I can make the test label.

sure we can give it a try

realrajaryan · 2025-11-05T21:32:02Z

.github/workflows/stale-pr.yml

+          
+          stale-pr-label: 'stale'
+
+          exempt-pr-labels: 'security,critical,dependencies'


these labels don't exist

Ronitsabhaya75 added 2 commits November 5, 2025 09:15

ci: add stale PR and issue management workflow

903ee25

ci: add stale PR and issue management workflow

69a7762

Ronitsabhaya75 changed the title ~~Add stale management~~ ci: add stale PR and issue management workflow Nov 5, 2025

update the pr stale and removed issues job, changed the timeline

bd65868

Ronitsabhaya75 changed the title ~~ci: add stale PR and issue management workflow~~ ci: add stale PR management workflow Nov 5, 2025

katiewasnothere reviewed Nov 5, 2025

View reviewed changes

Address Katie's feedback: update timelines, clarify messages, remove …

2184581

…emojis

Ronitsabhaya75 requested a review from katiewasnothere November 5, 2025 18:54

katiewasnothere reviewed Nov 5, 2025

View reviewed changes

realrajaryan reviewed Nov 5, 2025

View reviewed changes


		The PR will be closed in 30 days if there's no activity.

		If you need help or have questions, feel free to ask! We appreciate your contribution. 🙏


		stale-pr-label: 'stale'

		exempt-pr-labels: 'security,critical,dependencies'

ci: add stale PR management workflow #853

Are you sure you want to change the base?

ci: add stale PR management workflow #853

Uh oh!

Conversation

Ronitsabhaya75 commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Motivation and Context

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katiewasnothere commented Nov 5, 2025

Uh oh!

Ronitsabhaya75 commented Nov 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ronitsabhaya75 commented Nov 5, 2025 •

edited

Loading