Skip to content

Replace NSLock with Mutex #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Replace NSLock with Mutex #193

merged 2 commits into from
Jul 3, 2025

Conversation

@dkovba
Copy link
Contributor

@dkovba dkovba commented Jul 3, 2025 •
edited
Loading

This PR replaces NSLock with Mutex. Thanks @dcantah for the idea!

@dkovba dkovba requested a review from dcantah July 3, 2025 04:45
@dkovba dkovba changed the title Replace NSLock back with Mutex Replace NSLock with Mutex Jul 3, 2025
@dcantah
Copy link
Member

dcantah commented Jul 3, 2025

Nice, this doesn't see the issue you'd messaged about anymore?

@dcantah dcantah merged commit 969703d into apple:main Jul 3, 2025
2 checks passed
@dkovba
Copy link
Contributor Author

dkovba commented Jul 4, 2025

Nice, this doesn't see the issue you'd messaged about anymore?

Confirmed that this implementation doesn't have the issue we had with the previous implementation using a Mutex and a struct.

@dkovba dkovba deleted the mutex branch July 4, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkovba @dcantah