fix: numpy 2 prefers asarray() instead of copy=False #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @reneleonhardt for the PR.
Triggered a CI:
https://gitlab.com/coremltools1/coremltools/-/pipelines/1778702578
|
You're welcome! Everything was green, can you see if there were unexpected performance regressions? |
|
By the way, if speed (of your builds) is a concern to you, maybe you could look into https://codspeed.io it's free for Open-Source projects: https://docs.codspeed.io/integrations/ci/gitlab-ci |
Abdullah4345
approved these changes
Apr 26, 2025
|
@jakesabathia2 Is there something missing? |
|
@reneleonhardt your PR looks good to me. Let me merge it. Thanks! |
jakesabathia2
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read in an issue that in some cases
np.array(copy=False)fails: #2479 (comment)It's recommended to migrate to
np.asarray()(without copy):https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword