Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveJobs loop in cupsdCheckJobs() skips active pending jobs #4646

Closed
michaelrsweet opened this issue Jun 23, 2015 · 2 comments
Closed

ActiveJobs loop in cupsdCheckJobs() skips active pending jobs #4646

michaelrsweet opened this issue Jun 23, 2015 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 2.0-current
CUPS.org User: twaugh.redhat

When looping over the active jobs, if a pending job is started it will
have looped through the ActiveJobs array, meaning further pending
active jobs will be skipped for another 10 seconds (the senddoc
delay).

Fix attached.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"0001-Fix-the-ActiveJobs-loop-in-cupsdCheckJobs-STR-4646.patch":

From 4999ea81613f41e34715953b6d077e9b7522a238 Mon Sep 17 00:00:00 2001
From: Tim Waugh twaugh@redhat.com
Date: Tue, 23 Jun 2015 16:26:06 +0100
Subject: [PATCH] Fix the ActiveJobs loop in cupsdCheckJobs() (STR #4646)

When looping over the active jobs, if a pending job is started it will
have looped through the ActiveJobs array, meaning further pending
active jobs will be skipped for another 10 seconds (the senddoc

delay).

scheduler/job.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scheduler/job.c b/scheduler/job.c
index 956f9ff..82c5306 100644
--- a/scheduler/job.c
+++ b/scheduler/job.c
@@ -392,7 +392,9 @@ cupsdCheckJobs(void)
* Start the job...
*/

  • cupsArraySave(ActiveJobs);
    
    start_job(job, printer);
  • cupsArrayRestore(ActiveJobs);
    

    }
    }
    }

    2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant