-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cups_ll.po have outdated English translations of IPP attribute/value pairs #5495
Comments
OK, so the msgid's are IPP keyword/attribute+keyword combinations. The example strings were placed there because the underlying data source (the IANA IPP registry) and tools don't support adding comments (yet), so we have to include the US English equivalent somewhere. Putting it in the msgstr is a reasonable alternative while also ensuring that we have a backup translation. So for the meantime this will not be changing... |
I have now compared the pretranslated strings in cups.pot and cups_[LL].po files and it seems out of the 2149 strings that are pretranslated in 10 cups_[LL].po files there have only been a total of 2 translations done by translators. They are... cups_de.po:
Besides those 2 strings all the pretranslated strings in all the cups_[LL].po files are identical. Here is an example from cups.pot:
Yet in all the cups_[LL].po files the string is translated to:
I suspect that the pot file at some point contained 'msgstr "Mm"' but that this was later changed to 'msgstr "Millimeters"'. But because of the incorrect use of the PO format this change did not get into the po files. Which is done by adding fuzzy when there is a string change so translators can know about the change. Because of this i suggest removing all those 2149 pretranslated strings from the cups.pot and cups_[LL].po files. |
Here are the 440 differences between the cups.pot and one of the cups_[LL].po files.
|
Again, we can't do that. We need the English values for the keywords and cups.pot gets installed as cups_en.po (or the equivalent .strings file on macOS...) I'll see about cleaning these up in the other .po files... |
Note: This adds a cups_en.po file containing the real localized strings, with cups.pot pulling from ipp-strings.c which is generated from the IANA IPP registry. Localizer comments are included to help translators do all of those string... After the "purge", all of the non-English localization files are well below the 90% goal for translating... :(
OK, I've reworked how we generate the IPP attribute/value strings, such that cups.pot no longer contains translations but instead comments. A new cups_en.po file contains the English localizations, and we'll just need to periodically update that as needed. With the "purge" of the English strings from the non-English po files, we are now well below the target localization goal of no more than 10% unlocalized):
[master fe0d611] Update localization of IPP attribute/value pairs (Issue #5495) |
The string "Accuracy Units" is the string seeing by the user in the software right? And accuracy-units is somekind or id that the user dont see right? If that is the case the source string (english text) should be inside msgid. Instead of:
It should be:
|
No. "accuracy-units" is the IPP attribute name. The purpose of having a localization mapping from "accuracy-units" is so that a generic client can present UI for ANY attribute, and show the supported values for ANY value in the users chosen language. Similarly, state keywords ("media-empty" for "Out of paper", etc.) support vendor extensions and we want to be able to look up a localized string by the attribute and value to avoid ambiguity. We have also historically had contextual problems with strings like "color" and "resolution" - in English such words often carry multiple meanings but in other languages they are separate words. By using the IPP attribute and value strings we avoid such ambiguity since the attribute name provides the necessary context. |
Ok i dont quite understand but as long as its correct maybe i understand later. Maybe move:
To:
So all the ipp-strings.c stuff are at the bottom. |
Neither of those is part of the IPP strings... |
Thats way i wanted to move it up in the files so only the IPP strings are at the end of the file. |
How come the locale/cups.pot is 55.4 % translated?
Example:
I think this is incorrect use of the po format.
The source language (english) string should be in msgid and all msgstr should be empty in a pot file.
If translators needs to know "accuracy-units.mm" and "accuracy-units.nm" the info can be added like so:
The text was updated successfully, but these errors were encountered: