Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove build dir #5162

Merged
merged 2 commits into from
Jul 12, 2021
Merged

remove build dir #5162

merged 2 commits into from
Jul 12, 2021

Conversation

ammolitor
Copy link
Contributor

@ammolitor ammolitor commented Jul 12, 2021

remove the build dir. the docker image have been moved to another repo. the rest of this directory appears to be cruft that should be eliminated.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-mpilman sfc-gh-mpilman merged commit 2932047 into apple:master Jul 12, 2021
@ammolitor ammolitor deleted the remove_build_dir branch July 12, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants