Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow build folder as $BUILD_DIR #5195

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

PierreZ
Copy link
Contributor

@PierreZ PierreZ commented Jul 16, 2021

This PR is adding the build folder in the .gitignore, allowing IDE to use the standard $SOURCE_DIR/build, as discussed in #3098.

I didn't find any reference to a builds folder, so I changed it to build.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

ammolitor
ammolitor previously approved these changes Jul 16, 2021
Copy link
Contributor

@ammolitor ammolitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@sfc-gh-mpilman sfc-gh-mpilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gitignore change is probably a good one, but the documentation change is not advocating for what we consider best practice.

README.md Outdated Show resolved Hide resolved
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 072ed78
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 072ed78
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@sfc-gh-mpilman sfc-gh-mpilman merged commit 1e7db1b into apple:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants