Skip to content

Commit

Permalink
Don't require pr-approval/authenticate for PRB (#1)
Browse files Browse the repository at this point in the history
It's not actually necessary to require this job for PRBs.

This will allow us to run PRB workflows if the pr-approval/authenticate
job fails.

Co-authored-by: The Pkl Team (automation) <pkl-oss@groups.apple.com>
  • Loading branch information
bioball and The Pkl Team (automation) authored Mar 5, 2024
1 parent 8fd2146 commit 643aa4a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 2 additions & 6 deletions packages/pkl.impl.circleci/PklCI.pkl
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
/// CI job template specifically for Pkl projects.
module pkl.impl.circleci.PklCI

// TODO: Undo this hack to break the cycle; pkl-pantry depends on pkl-project-commons and vice-versa.
// Copied in `Config.pkl` locally, so that `pkl-project-commons` builds green and publishes.
// Releasing `pkl-project-commons` first allows `pkl-pantry` to be released dependent on it. After `pkl-pantry`
// is public, delete `Config.pkl` from this repository and use the `package://` import below.
import "@circleci/Config.pkl"

/// A map of user-selected names to either: orb references (strings) or orb definitions (maps).
Expand Down Expand Up @@ -214,13 +210,13 @@ local requireApproval = (it: String|Mapping<String, Config.WorkflowJob>) ->
if (it is String)
new Mapping<String, Config.WorkflowJob> {
[it] {
requires { "hold"; "pr-approval/authenticate" }
requires { "hold" }
}
}
else
(it) {
[it.keys.first] {
requires { "hold"; "pr-approval/authenticate" }
requires { "hold" }
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/pkl.impl.circleci/PklProject
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
amends "../basePklProject.pkl"

package {
version = "1.0.1"
version = "1.0.2"
}

dependencies {
Expand Down

0 comments on commit 643aa4a

Please sign in to comment.