Configure hawkeye to update license headers
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bioball
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Some comments:
- This script should add the license header if one is missing (with the current year as the copyright year).
- It should allow for different copyright formats (some copyrights use block comments, others use line comments).
- It should fetch from
origin/mainprior to execution, and the remote name should be changed if the env varPKL_ORIGINAL_REMOTE_NAMEis set. - It should accept a set of filenames (we want to format
.swiftand.pklfiles in this repo). It should also allow for a set of files to be excluded (we want to ignore generated `.pkl.swift files), for example.
KushalP
force-pushed
the
check-license
branch
from
1f78ba1 to
d09eb65
Compare
This comment was marked as outdated.
This comment was marked as outdated.
KushalP
force-pushed
the
check-license
branch
from
d09eb65 to
7217f8d
Compare
KushalP
changed the title
hawkeye to update license headers
You can test this with: ``` hawkeye check --fail-if-unknown ``` You can update header comments with: ``` hawkeye format --fail-if-unknown ``` Ref: https://github.com/korandoru/hawkeye/
KushalP
force-pushed
the
check-license
branch
from
7217f8d to
95a4431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this with:
You can update header comments with:
Ref: https://github.com/korandoru/hawkeye/