Respect line breaks in operator chains and argument lists #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
reviewed
Oct 29, 2025
pkl-formatter/src/test/files/FormatterSnippetTests/output/line-breaks.pkl
Outdated
Show resolved
Hide resolved
bioball
force-pushed
the
respect-line-breaks
branch
2 times, most recently
from
afbf15c to
3cef59b
Compare
| val children = node.children | ||
| val sep: (Node, Node) -> FormatNode = { prev, next -> | ||
| if (prev.isTerminal(",") && prev.linesBetween(next) > 0) forceSpaceyLine() else spaceOrLine() | ||
| } |
There was a problem hiding this comment.
This logic is arbitrary and error prone.
It doesn't work for many different cases or works by chance:
// doesn't multiline
p1 = foo(1
,2
,3)
// here it does
p2 = foo(1,
2
,3)
// doesn't multiline
p3 = foo(1, 2, 3, it
.asd)
// works by chance, because we respect newlines after comments
p4 = foo(1, 2, 3, /*foo*/
it)I think we should go back to the drawing board with this logic.
Maybe remove this part and merge the rest. This could be a subsequent PR.
There was a problem hiding this comment.
It's intentional that p3 doesn't multiline; per our formatting rules, it\n.bar should be single-lined, and this formatting rule shouldn't interfere with that. I also think it's fine that p4 works.
It's definitely a problem that p1 doesn't multiline; just pushed up a commit to fix that. Also, this also fixes an issue where this doesn't multiline:
1 +
2
stackoverflow
approved these changes
Oct 31, 2025
bioball
force-pushed
the
respect-line-breaks
branch
from
51d6fe4 to
c706685
Compare
If an operator chain or method call is multiline, keep those newlines in the formatted output. Help preserve code like: ``` foo |> (it) -> it + 2 |> (it) -> it / 2 ```
bioball
force-pushed
the
respect-line-breaks
branch
from
c706685 to
298126e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an operator chain or method call is multiline, keep those newlines in the formatted output.
Help preserve code like: