Fix default value evaluation in toTyped() #575
Conversation
Fix the issue where default values defined in the class are not properly generated when converting Dynamic or Map objects to Typed objects. Also, fix the issue where values are not properly generated for amended properties when making amends to the converted Typed objects.
There was a problem hiding this comment.
Very sorry for letting this sit so long and thanks for the contribution. I've created an issue for this (#768).
The approach in this PR is not quite right. toTyped should really produce an object with the class default in its prototype chain (i.e. the resulting object should have the same parent as if you'd evaluated new Person { name = "NewPigeon" }).readMember is invoked on the parent; although that doesn't change we need to revamp toTyped as per the below.)
Aside from that, the solution of introducing three readMember-like functions is costly (maintenance-wise). There is a much longer-standing issue with toTyped and that is that it is "shallow" (see issue #769). We intend to rework toTyped to cover all known issues (also issues #202 and #573).
|
Thank you for your response. I have also been contemplating various issues related to toTyped and have been solving them in my own way. Regarding issue #573, |
Fix the issue where default values defined in the class are not properly
generated when converting Dynamic or Map objects to Typed objects.
Also, fix the issue where values are not properly generated for amended
properties when making amends to the converted Typed objects.