Add methods from List/Map to Listing/Mapping
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odenix
reviewed
Oct 15, 2024
stackoverflow
previously requested changes
Oct 24, 2024
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
|
I'm missing |
holzensp
force-pushed
the
cleanMappingListingParity
branch
from
e55463f to
d689e46
Compare
odenix
reviewed
Oct 28, 2024
| @@ -128,6 +134,47 @@ public Map<Object, Object> toMap() { | |||
| return properties; | |||
| } | |||
|
|
|||
| public VmDynamic toDynamic() { | |||
| EconomicMap<Object, ObjectMember> members = EconomicMaps.create(this.members.size()); | |||
There was a problem hiding this comment.
I think this should use VmObjectBuilder
bioball
requested changes
Oct 30, 2024
There was a problem hiding this comment.
I have mostly nits, but also: I think we should punt these methods to another PR:
toDynamicMapping.entriesMapping.values
Also, there's still many methods that's missing! Not blocking, but it would be good to have. Here's what I see that I think we can add:
indexOfindexOfOrNulllastIndexOflastIndexOfOrNullfindfindOrNullfindLastfindLastOrNullfindIndexfindIndexOrNullfindLastIndexfindLastIndexOrNullcountfoldBackfoldIndexedreduceminminOrNullminByminByOrNullminWithminWithOrNullmaxmaxOrNullmaxBymaxByOrNullmaxWithmaxWithOrNullindexOf
pkl-core/src/main/java/org/pkl/core/stdlib/base/ListingNodes.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
bioball
approved these changes
Oct 31, 2024
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java
Outdated
Show resolved
Hide resolved
bioball
dismissed
stackoverflow’s stale review
comments have been addressed; reviewer currently unavailable to re-review
This reverts commit a7e8dfc
holzensp
force-pushed
the
cleanMappingListingParity
branch
from
c272732 to
1d2d51b
Compare
Co-authored-by: Daniel Chao <daniel.h.chao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods that "project out" of the type can be added to
ListingandMappingto avoid having to usetoList()/toMap(). Methods that result in aListing, resp.Mapping, are not included for performance and (lazy) semantics reasons, but methods likecontainsetc. can be defined straightforwardly.