Skip to content

Commit

Permalink
Increase timeout in flaky HttpMessageDiscardWatchdogServiceFilterTest (
Browse files Browse the repository at this point in the history
…#2757)

Motivation:

We've seen CI failures on this test. It looks like it's
probably just a short timeout.

Modifications:

- Increase the timeout in CI to 5 seconds.
  • Loading branch information
bryce-anderson authored Nov 14, 2023
1 parent bcb2825 commit 8f7c2ea
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import java.util.function.BiFunction;
import java.util.stream.Stream;

import static io.servicetalk.concurrent.internal.TestTimeoutConstants.CI;
import static io.servicetalk.http.netty.BuilderUtils.newClientBuilder;
import static io.servicetalk.http.netty.BuilderUtils.newServerBuilder;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -91,7 +92,7 @@ public Single<StreamingHttpResponse> handle(final HttpServiceContext ctx,
assertEquals(0, response.payloadBody().readableBytes());
}

String output = LoggerStringWriter.stableAccumulated(1000);
String output = LoggerStringWriter.stableAccumulated(CI ? 5000 : 1000);
assertTrue(output.contains("Discovered un-drained HTTP response message body which " +
"has been dropped by user code"));
}
Expand Down

0 comments on commit 8f7c2ea

Please sign in to comment.