Add example for gRPC using Maven #1091
Conversation
| <url>https://servicetalk.io</url> | ||
|
|
||
| <properties> | ||
| <servicetalk.version>0.29.0</servicetalk.version> |
There was a problem hiding this comment.
keeping versions up to date maybe painful down the line, but since this is meant to be an example from the user's perspective it is representative of actual use.
There was a problem hiding this comment.
Any way we can source gradle.properties and get the version?
There was a problem hiding this comment.
we maybe able to but because gradle and maven treat build dependencies differently using the version verbatim would lead to unresolved artifacts. I'll update the release script to bump this version.
Scottmitch
force-pushed
the
grpc_maven_example
branch
from
7c61a7d to
3091897
Compare
| import io.grpc.examples.helloworld.HelloReply; | ||
| import io.grpc.examples.helloworld.HelloRequest; | ||
|
|
||
| public final class BlockingHelloWorldClient { |
There was a problem hiding this comment.
Also add a server so the example is self sufficient?
There was a problem hiding this comment.
I just moved the pom.xml into the existing helloworld example to avoid duplication
| <url>https://servicetalk.io</url> | ||
|
|
||
| <properties> | ||
| <servicetalk.version>0.29.0</servicetalk.version> |
There was a problem hiding this comment.
Any way we can source gradle.properties and get the version?
Scottmitch
force-pushed
the
grpc_maven_example
branch
from
3091897 to
380c98c
Compare
No description provided.