Enhance connection: close tests to cover more use-cases on the server-side
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-side Motivation: Current tests for handling of `connection: close` header focused on the client side, missing some of the interesting server-side use-cases when request or response payload is delayed. Modifications: - Summarize all tests related to `connection: close` header in one class: `ConnectionCloseHeaderHandlingTest`; - Share secure proxy tunnel related code between `ConnectionCloseHeaderHandlingTest` and `HttpsProxyTest`; - Parametrize tests in `ConnectionCloseHeaderHandlingTest` to cover all combinations of request-response ordering; Result: Enhanced test coverage for `connection: close` handling logic.
idelpivnitskiy
commented
Jul 22, 2020
| import static java.util.concurrent.Executors.newCachedThreadPool; | ||
| import static java.util.concurrent.TimeUnit.MILLISECONDS; | ||
|
|
||
| final class ProxyTunnel implements AutoCloseable { |
There was a problem hiding this comment.
This code is moved from HttpsProxyTest without any changes.
NiteshKant
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current tests for handling of
connection: closeheader focused on the clientside, missing some of the interesting server-side use-cases when request or
response payload is delayed.
Modifications:
connection: closeheader in one class:ConnectionCloseHeaderHandlingTest;ConnectionCloseHeaderHandlingTestand
HttpsProxyTest;ConnectionCloseHeaderHandlingTestto cover allcombinations of request-response ordering;
Result:
Enhanced test coverage for
connection: closehandling logic.