Improve wrapping with the close reason #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We have two places in `DefaultNettyConnection` when we may need to wrap the error with known close reason. We can share this logic in both places consistently. Modifications: - Use `wrapIfReasonIsKnown` for `RetryableClosureException`; - Improve `wrapIfReasonIsKnown` to skip wrapping if the error is already wrapped with the same reason; Result: Consistent wrapping.
NiteshKant
approved these changes
Sep 4, 2020
|
@servicetalk-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have two places in
DefaultNettyConnectionwhen we may need to wrapthe error with known close reason. We can share this logic in both places
consistently.
Modifications:
wrapIfReasonIsKnownforRetryableClosureException;wrapIfReasonIsKnownto skip wrapping if the error is alreadywrapped with the same reason;
Result:
Consistent wrapping.