Support write of read-only Buffer
(s) for HTTP/2
#1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ServiceTalk provides a default
BufferAllocator
backed by netty'sByteBufAllocator
, but also provides aReadOnlyBufferAllocator
implementation that does not depend on netty.
AbstractH2DuplexHandler
currently supports only
ServiceTalkBufferAllocator
.Modifications:
encodeAndRetain
logic between HTTP/1.x and HTTP/2 encoders;BufferAllocator
s;HttpProtocol
enum between different tests;ReadOnlyBufferAllocator.toString()
for better output for testparameters;
Result:
HTTP/2 encoder supports
Buffer
s produced byReadOnlyBufferAllocator
.