Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and examples for mutual TLS #1179

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

Scottmitch
Copy link
Member

Motivation:
We currently do not have unit tests and examples dedicated to mutual TLS.

Modifications:

  • Add client/server example for HTTP which demonstrates mutual TLS
  • Add HTTP unit test which verifies expected behavior for mutual tls
  • Update scripts to generate client/server variants of certificates and
    generate the new certificates

Result:
Unit test and examples exist for mutual TLS

Motivation:
We currently do not have unit tests and examples dedicated to mutual
TLS.

Modifications:
- Add client/server example for HTTP which demonstrates mutual TLS
- Add HTTP unit test which verifies expected behavior for mutual tls
- Update scripts to generate client/server variants of certificates and
generate the new certificates

Result:
Unit test and examples exist for mutual TLS
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you added separate certs for the client. Can you please also use new client certs here?

clientSecurityConfig.keyManager(DefaultTestCerts::loadServerPem, DefaultTestCerts::loadServerKey);

@Scottmitch Scottmitch merged commit 3d57030 into apple:main Oct 14, 2020
@Scottmitch Scottmitch deleted the mutual_tls branch October 14, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants