Verify that all graceful closure use-cases also work with HTTP/2 #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `GracefulConnectionClosureHandlingTest` provides a comprehensive testing for graceful closure with HTTP/1. We need to make sure, the same cases work correctly when users switch to HTTP/2. Modifications: - Add `HttpProtocol` parameter for `GracefulConnectionClosureHandlingTest`; Result: All use-cases of `GracefulConnectionClosureHandlingTest` are tested with HTTP/1.x and HTTP/2.
Scottmitch
approved these changes
Oct 15, 2020
| @@ -479,6 +497,10 @@ private void assertClosedChannelException(ThrowingRunnable runnable, CloseEvent | |||
| Exception e = assertThrows(ExecutionException.class, runnable); | |||
| Throwable cause = e.getCause(); | |||
| assertThat(cause, instanceOf(ClosedChannelException.class)); | |||
| if (protocol == HTTP_2) { | |||
| // HTTP/2 does not enhance ClosedChannelException with CloseEvent | |||
There was a problem hiding this comment.
this is an unfortunate side effect of error handling being coupled to the close handler. we should consider a followup effort to preserve the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GracefulConnectionClosureHandlingTestprovides a comprehensive testingfor graceful closure with HTTP/1. We need to make sure, the same cases
work correctly when users switch to HTTP/2.
Modifications:
HttpProtocolparameter forGracefulConnectionClosureHandlingTest;Result:
All use-cases of
GracefulConnectionClosureHandlingTestare tested withHTTP/1.x and HTTP/2.