Improve servicetalk-test-resources/log4j2.xml
#1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Wire logger and h2 frame logger are controlled by the logger configuration
after #1123. It allows us to use these logger names in tests and enabled them
via system property when required for local debugging.
Having 2 different logger names for client and server controlled by a single
system property does not help much. We can use a thread name to understand
if a logger statement belongs to a client or to a server. A single logger name
simplifies usage in tests.
Modifications:
servicetalk-tests-wire-logger
logger name;servicetalk-tests-h2-frame-logger
logger name andservicetalk.logger.h2FrameLogLevel
system property to control visibilityfor h2 frames;
Result:
Separate system properties to control wire logger and h2 frame logger.