Make HttpObjectDecoder more RFC7230 compatible and other improvements
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RFC7230 defines `obs-text` as `%x80-FF` (any negative byte value), and reason-phrase as `*( HTAB / SP / VCHAR / obs-text )`. Modifications: - Adjust `isObsText` and reason-phrase validation according to RFC7230; - Verify that the passed `closeHandler` is non-null; - Return fast if the buffer is not readable after skipping control chars; Result: `HttpObjectDecoder` is more robust and RFC7230 compatible.
Scottmitch
approved these changes
Nov 20, 2020
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/HttpObjectDecoder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RFC7230 defines
obs-textas%x80-FF(any negative byte value), andreason-phrase as
*( HTAB / SP / VCHAR / obs-text ).Modifications:
isObsTextand reason-phrase validation according to RFC7230;closeHandleris non-null;Result:
HttpObjectDecoderis more robust and RFC7230 compatible.