Fix incorrect numbers reported by DnsResolutionObserver#resolutionCompleted
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpleted` Motivation: `DnsResolutionObserver#resolutionCompleted` returns incorrect numbers for `ResolutionResult` when some addresses become unavailable. Modifications: - Fix metrics bug in `ServiceDiscovererUtils.calculateDifference`; - Add tests to verify we correctly report numbers when DNS returns different resolution updates; Result: `DnsResolutionObserver#resolutionCompleted` correctly reports number of available and unavailable records.
idelpivnitskiy
force-pushed
the
ResolutionResultBug
branch
from
2858ff5 to
4a35100
Compare
tkountis
approved these changes
Dec 10, 2020
|
Test failure #1265 @servicetalk-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
DnsResolutionObserver#resolutionCompletedreturns incorrect numbers forResolutionResultwhen some addresses become unavailable.Modifications:
ServiceDiscovererUtils.calculateDifference;resolution updates;
BlockingQueueinstead ofListinDnsServiceDiscovererObserverTest;Result:
DnsResolutionObserver#resolutionCompletedcorrectly reports number ofavailable and unavailable records.