DefaultSingleAddressHttpClient
may add incorrect host
header by default
#1301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Existing approach for adding
HostHeaderHttpRequesterFilter
inDefaultSingleAddressHttpClientBuilder
keeps reference to thehostToCharSequenceFunction
at the time of class initialization. However,hostToCharSequenceFunction
can be changed later (in a proxy ctor orunresolvedAddressToHost
builder method). In these cases,hostHeaderFilterFactoryFunction
keeps the reference to the oldhostToCharSequenceFunction
.Modifications:
boolean
to know whenHostHeaderHttpRequesterFilter
should beapplied;
HostHeaderHttpRequesterFilter
is added, use the latest reference tothe
hostToCharSequenceFunction
;Result:
HostHeaderHttpRequesterFilter
uses the latest version ofhostToCharSequenceFunction
to determine the fallback value for thehost
header.