Make ServiceTalkWireLogger consistent with LoggingHandler
#1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `ServiceTalkWireLogger` is a rework if netty's `LoggingHandler` which allows us to control logging of user data. However, the output format was a bit different from netty, making it harder to compare netty and ST logs. Also, it has a few minor issues with the output. Modifications: - Align output format with `LoggingHandler`; - Make internal methods `static` when possible; - Do not print extra new line when buffer is empty; - Log how `Channel`'s writability changed; - Do not log `localAddress` when it's `null`; Result: Output of `ServiceTalkWireLogger` and `LoggingHandler` is aligned.
tkountis
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ServiceTalkWireLoggeris a rework if netty'sLoggingHandlerwhich allowsus to control logging of user data. However, the output format was a bit
different from netty, making it harder to compare netty and ST logs. Also,
it has a few minor issues with the output.
Modifications:
LoggingHandler;staticwhen possible;Channel's writability changed;localAddresswhen it'snull;Result:
Output of
ServiceTalkWireLoggerandLoggingHandleris aligned.