Examples for HTTP and gRPC compression #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I had intended to propose these as separate PRs. Oh well, they are fine together. Both HTTP and gRPC examples are now included in the PR. |
There was a problem hiding this comment.
Great work @bondolo!
Can you please update PR title and description to account for gRPC examples as well?
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleClient.java
Outdated
Show resolved
Hide resolved
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleClient.java
Show resolved
Hide resolved
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleServer.java
Outdated
Show resolved
Hide resolved
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleServer.java
Outdated
Show resolved
Hide resolved
...es/grpc/compression/src/main/java/io/servicetalk/examples/grpc/compression/package-info.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/io/servicetalk/examples/http/compression/CompressionFilterExampleServer.java
Outdated
Show resolved
Hide resolved
bondolo
changed the title
tkountis
reviewed
Jan 31, 2021
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleClient.java
Outdated
Show resolved
Hide resolved
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleServer.java
Outdated
Show resolved
Hide resolved
servicetalk-examples/grpc/compression/src/main/resources/log4j2.xml
Outdated
Show resolved
Hide resolved
Motivation: Provide an example demonstrating use of the content encoding compression features. Modifications: - A new HTTP example, Compression - Additional documentation Result: No further need to reference test code to understand how to use compression features.
bondolo
force-pushed
the
main
branch
2 times, most recently
from
9408dc3 to
8b3962b
Compare
idelpivnitskiy
approved these changes
Feb 2, 2021
...ression/src/main/java/io/servicetalk/examples/grpc/compression/CompressionExampleServer.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
changed the title
Motivation: Provide an example demonstrating use of the content encoding compression features. Modifications: - A new gRPC example, Compression - Additional documentation Result: No further need to reference test code to understand how to use compression features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provide an example demonstrating use of the content encoding compression features.
Modifications:
Result:
No further need to reference test code to understand how to use compression features.