Let users opt-in for app initialization failures without native libs #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#1979 fails app initialization if native transport libs can not be loaded. This is too aggressive. Instead, keep warning users and let them opt-in for the enforced behavior. Modifications: - Fail initialization only if users explicitly opt-it for this using `-Dio.servicetalk.transport.netty.requireNativeLibs=true`; - Improve exception and log messages; Result: Users can enforce requirement for native libs if they need.
idelpivnitskiy
requested review from
bondolo,
chemicL,
tkountis and
Scottmitch
bondolo
approved these changes
Dec 10, 2021
|
Because it's not an enforced behavior anymore, I'm going to cherry-pick this into 0.41 |
idelpivnitskiy
added a commit
that referenced
this pull request
Dec 10, 2021
…2006) Motivation: #1979 fails app initialization if native transport libs can not be loaded. This is too aggressive. Instead, keep warning users and let them opt-in for the enforced behavior. Modifications: - Fail initialization only if users explicitly opt-it for this using `-Dio.servicetalk.transport.netty.requireNativeLibs=true`; - Improve exception and log messages; Result: Users can enforce requirement for native libs if they need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#1979 fails app initialization if native transport libs can not be
loaded. This is too aggressive. Instead, keep warning users and let
them opt-in for the enforced behavior.
Modifications:
-Dio.servicetalk.transport.netty.requireNativeLibs=true;Result:
Users can enforce requirement for native libs if they need.