Update offloading documentation #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondolo
requested review from
chemicL,
tkountis,
idelpivnitskiy and
Scottmitch
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jan 7, 2022
...lk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapMergeTest.java
Outdated
Show resolved
Hide resolved
chemicL
previously requested changes
Jan 7, 2022
...lk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapMergeTest.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
Scottmitch
requested changes
Jan 7, 2022
...lk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapMergeTest.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
Motivation: ServiceTalk 0.42 introduced significant changes to the behavior of offloading and the documentation needs to be updated Modifications: Adjust and expand existing offloading documentation to describe the current behavior. Result: More complete and accurate ServiceTalk documentation.
- Adds markup to svg to improve accessibility.
bondolo
force-pushed
the
offloading-docs
branch
from
cdfa177 to
ab54e30
Compare
Scottmitch
previously requested changes
Mar 16, 2022
servicetalk-concurrent-api/docs/modules/ROOT/assets/images/blocking-scenarios.svg
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-implementation.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-safe-by-default.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-safe-by-default.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-safe-by-default.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/blocking-safe-by-default.adoc
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/docs/modules/ROOT/pages/pitfalls.adoc
Outdated
Show resolved
Hide resolved
bondolo
dismissed stale reviews from Scottmitch and chemicL
Dismissing stale requested changes, all requests have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ServiceTalk 0.42 introduced significant changes to the behavior of
offloading and the documentation needs to be updated
Modifications:
Adjust and expand existing offloading documentation to describe the
current behavior.
Result:
More complete and accurate ServiceTalk documentation.