Remove examples for multi-address client that similar to single-address #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some HTTP examples that use `HttpClients.forMultiAddressUrl()` are identical to the other example that uses `HttpClients.forSingleAddress(...)`. It doesn't provide much value for users because the top level client API is the same for both client factories. It's enough to demonstrate multi-address use-case in hello-world example only. Modifications: - Remove classes that target `forMultiAddressUrl()` from json, protobuf, and retry examples; - Remove link to `RetryUrlClient` from docs; Result: Less classes in examples to maintain.
|
I have no objection to these specific changes but would like to see at least one example of using an initializer, even if we have to do something contrived. Without an example users are likely to miss how they are to apply configuration to instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some HTTP examples that use
HttpClients.forMultiAddressUrl()areidentical to the other example that uses
HttpClients.forSingleAddress(...). It doesn't provide much value forusers because the top level client API is the same for both client
factories. It's enough to demonstrate multi-address use-case in
hello-world example only.
Modifications:
forMultiAddressUrl()from json, protobuf,and retry examples;
RetryUrlClientfrom docs;Result:
Less classes in examples to maintain.