Allow override of the HttpHeadersFactory for multi-address and partitioned clients
#2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itioned clients Motivation: A client instance is also used to create a request object because it implements request-response factory. Users of multi-address and partitioned clients always use `DefaultHttpHeadersFactory.INSTANCE`. There is no easy way to override headers factory. Use-cases: change header name/value validation, preset some headers, etc. Modifications: - Add `MultiAddressHttpClientBuilder#headersFactory(HttpHeadersFactory)` - Add `PartitionedHttpClientBuilder#headersFactory(HttpHeadersFactory)` - Implement new methods; - Test new feature for `MultiAddressHttpClientBuilder`; Result: Users of multi-address and partitioned clients can override the default `HttpHeadersFactory`.
idelpivnitskiy
force-pushed
the
headers-factory
branch
from
32326f5 to
e8c092a
Compare
chemicL
approved these changes
Mar 9, 2022
| import static java.util.Objects.requireNonNull; | ||
| import static java.util.function.Function.identity; | ||
|
|
||
| final class DefaultPartitionedHttpClientBuilder<U, R> implements PartitionedHttpClientBuilder<U, R> { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(DefaultMultiAddressUrlHttpClientBuilder.class); | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(DefaultPartitionedHttpClientBuilder.class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A client instance is also used to create a request object because it
implements a request-response factory. Users of multi-address and
partitioned clients always use
DefaultHttpHeadersFactory.INSTANCE.There is no easy way to override headers factory. Use-cases: change
header name/value validation, preset some headers, etc.
Modifications:
MultiAddressHttpClientBuilder#headersFactory(HttpHeadersFactory)PartitionedHttpClientBuilder#headersFactory(HttpHeadersFactory)MultiAddressHttpClientBuilder;Result:
Users of multi-address and partitioned clients can override the default
HttpHeadersFactory.