Remove proxy-connection header from outgoing HTTP/2 messages
#2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Quote from the spec (https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.2): This means that an intermediary transforming an HTTP/1.x message to HTTP/2 will need to remove any header fields nominated by the Connection header field, along with the Connection header field itself. Such intermediaries SHOULD also remove other connection- specific header fields, such as Keep-Alive, Proxy-Connection, Transfer-Encoding, and Upgrade, even if they are not nominated by the Connection header field. `H2ToStH1Utils.h1HeadersToH2Headers()` removes all described headers except `proxy-connection`. Modifications: - Remove `proxy-connection` header from the outgoing HTTP/2 messages; - Test that HTTP/2 client and server remove prohibited headers; Result: Outgoing HTTP/2 messages never contain prohibited `proxy-connection` header.
Scottmitch
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Quote from the spec
(https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.2):
H2ToStH1Utils.h1HeadersToH2Headers()removes all described headersexcept
proxy-connection.Modifications:
proxy-connectionheader from the outgoing HTTP/2 messages;Result:
Outgoing HTTP/2 messages never contain prohibited
proxy-connectionheader.